spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [CORE] [TEST] Fix SimpleDateParamTest
Date Sat, 23 May 2015 09:55:34 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6377#discussion_r30943672
  
    --- Diff: core/src/test/scala/org/apache/spark/status/api/v1/SimpleDateParamTest.scala
---
    @@ -21,6 +21,11 @@ import org.scalatest.{Matchers, FunSuite}
     class SimpleDateParamTest extends FunSuite with Matchers {
     
       test("date parsing") {
    +    import java.util.{Locale, TimeZone}
    --- End diff --
    
    If so, then the whole test framework should set a default timezone globally. However,
it's really not good to rely on this.
    
    There seems to be a bug as this logic really can't depend on the current machine's timezone.
"2015-02-20T23:21:17.190GMT" unambiguously names a point in time. So I don't htink we can
commit this as a fix but rather root out the bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message