spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7663][MLlib] Add requirement for word2v...
Date Mon, 18 May 2015 07:38:16 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6228#discussion_r30486269
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
    @@ -410,6 +410,9 @@ class Word2Vec extends Serializable with Logging {
           i += 1
         }
     
    +    require(word2VecMap.size > 0, "The word2vec map should not be empty. You may need
to check " +
    --- End diff --
    
    This could be `nonEmpty`, but isn't this already determined by whether `vocabSize == 0`?
I don't know this code well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message