spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7681][MLlib] Add SparseVector support f...
Date Sun, 17 May 2015 05:37:08 GMT
Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6209#discussion_r30467629
  
    --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala ---
    @@ -270,17 +271,26 @@ class BLASSuite extends FunSuite {
         val expected2 = new DenseVector(Array(6.0, 7.0, 4.0, 9.0))
         val expected3 = new DenseVector(Array(10.0, 8.0, 6.0, 18.0))
     
    -    gemv(1.0, dA, x, 2.0, y1)
    -    gemv(1.0, sA, x, 2.0, y2)
    -    gemv(2.0, dA, x, 2.0, y3)
    -    gemv(2.0, sA, x, 2.0, y4)
    +    gemv(1.0, dA, dx, 2.0, y1)
    +    gemv(1.0, sA, dx, 2.0, y2)
    +    gemv(2.0, dA, dx, 2.0, y3)
    +    gemv(2.0, sA, dx, 2.0, y4)
    --- End diff --
    
    To the following instead.
    ```
        gemv(1.0, dA, dx, 2.0, y1)
        gemv(1.0, sA, dx, 2.0, y2)
        gemv(1.0, dA, sx, 2.0, y3)
        gemv(1.0, sA, sx, 2.0, y4)
    
        gemv(2.0, dA, dx, 2.0, y5)
        gemv(2.0, sA, dx, 2.0, y6)
        gemv(2.0, dA, sx, 2.0, y7)
        gemv(2.0, sA, sx, 2.0, y8)
    
        assert(y1 ~== expected2 absTol 1e-15)
        assert(y2 ~== expected2 absTol 1e-15)
        assert(y3 ~== expected3 absTol 1e-15)
        assert(y4 ~== expected3 absTol 1e-15)
        assert(y5 ~== expected2 absTol 1e-15)
        assert(y6 ~== expected2 absTol 1e-15)
        assert(y7 ~== expected3 absTol 1e-15)
        assert(y8 ~== expected3 absTol 1e-15)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message