spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [Spark-7511][MLLIB] pyspark ml seed param shou...
Date Fri, 15 May 2015 00:48:30 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6139#discussion_r30377854
  
    --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
    @@ -115,7 +118,7 @@ def get$Name(self):
             ("outputCol", "output column name", None),
             ("numFeatures", "number of features", None),
             ("checkpointInterval", "checkpoint interval (>= 1)", None),
    -        ("seed", "random seed", None),
    +        ("seed", "random seed", "random.randint(0, sys.maxsize)"),
    --- End diff --
    
    Yes, in Scala, we use a random seed each time.  (See the code gen file for HasSeed, or
several examples in spark.mllib.)  I think that's the best behavior: By default, we use a
random seed.  If users want reproducible behavior, they should set the seed manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message