spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adrian-wang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7150] add range() api
Date Thu, 14 May 2015 06:07:28 GMT
Github user adrian-wang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6081#discussion_r30299903
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -689,6 +689,64 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
         new ParallelCollectionRDD[T](this, seq, numSlices, Map[Int, Seq[String]]())
       }
     
    +  /**
    +   * Creates a new RDD[Long] containing elements from `start` to `end`(exclusive), increased
by
    +   * `step` every element.
    +   *
    +   * @note if we need to cache this RDD, we should make sure each partition contains
no more than
    +   *       2 billion element.
    +   *
    +   * @param start the start value.
    +   * @param end the end value.
    +   * @param step the incremental step
    +   * @param numSlices the partition number of the new RDD.
    +   * @return
    +   */
    +  def range(
    +      start: Long,
    +      end: Long,
    +      step: Long = 1,
    +      numSlices: Int = defaultParallelism): RDD[Long] = withScope {
    +    assertNotStopped()
    +    if (step == 0) {
    --- End diff --
    
    I don't think these should throw exception. In my implementation it just return an empty
RDD.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message