spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7504] [YARN] NullPointerException when ...
Date Tue, 12 May 2015 18:30:51 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6083#discussion_r30165277
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
    @@ -573,10 +573,16 @@ object ApplicationMaster extends Logging {
       }
     
       private[spark] def sparkContextInitialized(sc: SparkContext): Unit = {
    +    if (master == null){
    --- End diff --
    
    Yes, you could reach this, but the NPE at that point was just a side effect of a different
bug. Fix that bug, NPE is gone. Remove the NPE, but leave the bug in, something else will
blow up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message