spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6263][MLLIB] Python MLlib API missing i...
Date Sat, 09 May 2015 22:57:37 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5707#discussion_r29997018
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala
---
    @@ -71,6 +71,16 @@ private[python] class PythonMLLibAPI extends Serializable {
           minPartitions: Int): JavaRDD[LabeledPoint] =
         MLUtils.loadLabeledPoints(jsc.sc, path, minPartitions)
     
    +  /**
    +   * Loads and serializes vectors saved with `RDD#saveAsTextFile`.
    +   * @param jsc Java SparkContext
    +   * @param path file or directory path in any Hadoop-supported file system URI
    +   * @return serialized vectors in a RDD
    +   */
    +  def loadVectors(jsc: JavaSparkContext,
    --- End diff --
    
    scala style: If this method declaration will fit on 1 line, then please do so. (I think
it will.)  Otherwise, the parameters should start in the line below the method name and be
indented 4 spaces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message