spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7484][SQL]Support jdbc connection prope...
Date Sat, 09 May 2015 21:03:07 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6009#discussion_r29996300
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -911,15 +911,14 @@ class SQLContext(@transient val sparkContext: SparkContext)
       /**
        * :: Experimental ::
        * Construct a [[DataFrame]] representing the database table accessible via JDBC URL
    -   * url named table.
    +   * url named table and connection properties.
        *
        * @group specificdata
        */
       @Experimental
    -  def jdbc(url: String, table: String): DataFrame = {
    -    jdbc(url, table, JDBCRelation.columnPartition(null))
    +  def jdbc(url: String, table: String, properties: Properties = new Properties()): DataFrame
= {
    --- End diff --
    
    same as above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message