spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7462] By default retain group by column...
Date Sat, 09 May 2015 05:06:02 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5996#discussion_r29989821
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
    @@ -233,6 +236,9 @@ private[sql] class SQLConf extends Serializable {
     
       private[spark] def dataFrameSelfJoinAutoResolveAmbiguity: Boolean =
         getConf(DATAFRAME_SELF_JOIN_AUTO_RESOLVE_AMBIGUITY, "true").toBoolean
    +
    +  private[spark] def dataFrameRetainGroupColumns: Boolean =
    +    getConf(DATAFRAME_RETAIN_GROUP_COLUMNS, "true").toBoolean
    --- End diff --
    
    let's talk more about this. if we want to do it, we should do it in 1.4.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message