spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7199][SQL] Add date and timestamp suppo...
Date Fri, 08 May 2015 00:06:46 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5984#discussion_r29907828
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
    @@ -107,7 +109,9 @@ public static int calculateBitSetWidthInBytes(int numFields) {
         // We support get() on a superset of the types for which we support set():
         final Set<DataType> _readableFieldTypes = new HashSet<DataType>(
           Arrays.asList(new DataType[]{
    -        StringType
    +        StringType,
    +        DateType,
    --- End diff --
    
    Once we support `setDate`, then we should move this to the other list, `settableFieldTypes`,
defined right before this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message