spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5893][ML] Add bucketizer
Date Thu, 07 May 2015 18:51:09 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5980#discussion_r29883626
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala ---
    @@ -0,0 +1,118 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ml.feature
    +
    +import org.apache.spark.annotation.AlphaComponent
    +import org.apache.spark.ml.attribute.NominalAttribute
    +import org.apache.spark.ml.param._
    +import org.apache.spark.ml.param.shared.{HasInputCol, HasOutputCol}
    +import org.apache.spark.ml.util.SchemaUtils
    +import org.apache.spark.ml.{Estimator, Model}
    +import org.apache.spark.sql._
    +import org.apache.spark.sql.functions._
    +import org.apache.spark.sql.types.{DoubleType, StructType}
    +
    +/**
    + * :: AlphaComponent ::
    + * `Bucketizer` maps a column of continuous features to a column of feature buckets.
    + */
    +@AlphaComponent
    +final class Bucketizer(override val parent: Estimator[Bucketizer] = null)
    +  extends Model[Bucketizer] with HasInputCol with HasOutputCol {
    +
    +  /**
    +   * The given buckets should match 1) its size is larger than zero; 2) it is ordered
in a non-DESC
    +   * way.
    +   */
    +  private def checkBuckets(buckets: Array[Double]): Boolean = {
    --- End diff --
    
    Should this be static?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message