spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7308][WIP] prevent concurrent attempts ...
Date Thu, 07 May 2015 04:31:46 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5964#discussion_r29823869
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
    @@ -773,6 +774,64 @@ class DAGSchedulerSuite
         assertDataStructuresEmpty()
       }
     
    +  ignore("no concurrent retries for stage attempts (SPARK-7308)") {
    --- End diff --
    
    ignored b/c it spawns 10 executors, takes about 2 mins on my laptop, and makes everything
pretty sluggish -- I didn't want to swamp jenkins.  I tried a variety of permutations and
this consistently demonstrated the problem for me, but maybe we can pare this down some. 
(Or maybe we need another home for tests like this?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message