spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adrian-wang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7330] [SQL] avoid NPE at jdbc rdd
Date Wed, 06 May 2015 03:04:10 GMT
Github user adrian-wang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5877#discussion_r29731745
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala ---
    @@ -361,8 +361,14 @@ private[sql] class JDBCRDD(
               val pos = i + 1
               conversions(i) match {
                 case BooleanConversion    => mutableRow.setBoolean(i, rs.getBoolean(pos))
    --- End diff --
    
    For now only Date will have the NPE problem. in #5456 when I convert the decimal type
there I also apply similar approach when I call `def Decimal(x: BigDecimal)`.
    I have add another test case to make sure it works for all types.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message