spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6939][Streaming][WebUI] Add timeline an...
Date Tue, 05 May 2015 09:10:32 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5533#discussion_r29653070
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/ui/UIUtils.scala ---
    @@ -0,0 +1,74 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.streaming.ui
    +
    +import java.util.concurrent.TimeUnit
    +
    +object UIUtils {
    +
    +  /**
    +   * Return the short string for a `TimeUnit`.
    +   */
    +  def shortTimeUnitString(unit: TimeUnit): String = unit match {
    +    case TimeUnit.NANOSECONDS => "ns"
    +    case TimeUnit.MICROSECONDS => "us"
    +    case TimeUnit.MILLISECONDS => "ms"
    +    case TimeUnit.SECONDS => "sec"
    +    case TimeUnit.MINUTES => "min"
    +    case TimeUnit.HOURS => "hrs"
    +    case TimeUnit.DAYS => "days"
    +  }
    +
    +  /**
    +   * Find the best `TimeUnit` for converting milliseconds to a friendly string. Return
the value
    +   * after converting, also with its TimeUnit.
    +   */
    +  def normalizeDuration(milliseconds: Long): (Double, TimeUnit) = {
    --- End diff --
    
    Yes, but this one requires normalizing and getting the unit by which it is normalized.
And later we will use the same unit to normalize others time intervals. This is so that we
can set the max Y-axis range and corresponding time unit for all the histograms and then map
all other values using the same unit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message