spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2750][WEB UI]Add Https support for Web ...
Date Mon, 04 May 2015 18:15:52 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5664#discussion_r29608356
  
    --- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
    @@ -149,12 +157,20 @@ private[spark] object SSLOptions extends Logging {
         val keyPassword = conf.getOption(s"$ns.keyPassword")
             .orElse(defaults.flatMap(_.keyPassword))
     
    +    val keyStoreType = conf.getOption(s"$ns.keyStoreType")
    --- End diff --
    
    I see you adding these new properties but I don't see them used? Shouldn't `createJettySslContextFactory`
and potentially `createAkkaConfig` be modified?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message