spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brkyvz <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7243][SQL] Contingency Tables for DataF...
Date Mon, 04 May 2015 05:47:13 GMT
Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5842#discussion_r29566986
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
    @@ -77,4 +79,27 @@ private[sql] object StatFunctions {
           })
         counts.cov
       }
    +
    +  /** Generate a table of frequencies for the elements of two columns. */
    +  private[sql] def crossTabulate(df: DataFrame, col1: String, col2: String): DataFrame
= {
    +    val tableName = s"${col1}_$col2"
    +    val counts = df.groupBy(col1, col2).agg(col(col1), col(col2), count("*")).collect()
    --- End diff --
    
    do we know how much we are going to `take` though?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message