spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7308][core] fail fast when we detect mu...
Date Sat, 02 May 2015 00:36:40 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5844#discussion_r29542881
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkException.scala ---
    @@ -30,3 +30,12 @@ class SparkException(message: String, cause: Throwable)
      */
     private[spark] class SparkDriverExecutionException(cause: Throwable)
       extends SparkException("Execution error", cause)
    +
    +/**
    + * Exception indicating an error internal to Spark, not caused by user error
    + */
    +class SparkInternalStateException(message: String, cause: Throwable)
    --- End diff --
    
    yeah, I wasn't sure what to name it -- I wanted the name to clearly indicate to the user
that the error wasn't their fault, and there isn't anything they can do about it.  I guess
your version is better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message