spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2808][Streaming][Kafka] update kafka to...
Date Fri, 01 May 2015 20:56:40 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4537#discussion_r29533046
  
    --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaCluster.scala
---
    @@ -37,6 +38,11 @@ private[spark]
     class KafkaCluster(val kafkaParams: Map[String, String]) extends Serializable {
       import KafkaCluster.{Err, LeaderOffset, SimpleConsumerConfig}
     
    +  /** Constructor that takes a Java map */
    +  def this(kafkaParams: java.util.Map[String, String]) {
    --- End diff --
    
    Is this used anywhere? If it is not, then why was this added?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message