spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6980] [CORE] [WIP] Akka timeout excepti...
Date Fri, 01 May 2015 06:09:49 GMT
Github user BryanCutler commented on the pull request:

    https://github.com/apache/spark/pull/5741#issuecomment-98053574
  
    Thanks for the quick feedback @squito!  I probably should have explained a little, but
I only added the implicit conversion to maintain api compatibility by also allowing a {{FiniteDuration}}
input parameter.  If that's not needed then I can definitely remove it.
    
    I'll fix up the code with your suggestions and see what I can do about adding a test case
for this.  Hopefully, be able to get it done in the next couple days.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message