Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: rxin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-5430-spark@git.apache.org>
In-Reply-To: <git-pr-5430-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-6479][Block Manager]Create
 off-heap blo...
Content-Type: text/plain
Message-Id: <20150423003548.EC8AADFF0B@git1-us-west.apache.org>
Date: Thu, 23 Apr 2015 00:35:48 +0000 (UTC)

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5430#discussion_r28928005
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/ExtBlockStore.scala ---
    @@ -0,0 +1,169 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.storage
    +
    +import java.nio.ByteBuffer
    +import org.apache.spark.Logging
    +import org.apache.spark.util.Utils
    +
    +import scala.util.control.NonFatal
    +
    +
    +/**
    + * Stores BlockManager blocks on ExtBlkStore.
    + * We capture any potential exception from underlying implementation
    + * and return with the expected failure value
    + */
    +private[spark] class ExtBlockStore(blockManager: BlockManager, executorId: String)
    +  extends BlockStore(blockManager: BlockManager) with Logging {
    +
    +  lazy val extBlkStoreManager: Option[ExtBlockManager] = createBlkManager()
    +
    +  logInfo("ExtBlkStore started")
    +
    +  override def getSize(blockId: BlockId): Long = {
    +    try {
    +      extBlkStoreManager.map(_.getSize(blockId)).getOrElse(0)
    +    } catch {
    +      case NonFatal(t) => logError(s"error in getSize from $blockId", t)
    --- End diff --
    
    put this on the 2nd line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org