Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB500179F9 for ; Fri, 17 Apr 2015 04:14:41 +0000 (UTC) Received: (qmail 53274 invoked by uid 500); 17 Apr 2015 04:05:19 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 36077 invoked by uid 500); 17 Apr 2015 04:05:05 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 18496 invoked by uid 99); 17 Apr 2015 03:11:33 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Apr 2015 03:11:33 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3708BDFE2C; Fri, 17 Apr 2015 03:11:33 +0000 (UTC) From: rxin To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-6957] [SPARK-6958] [SQL] improve API co... Content-Type: text/plain Message-Id: <20150417031133.3708BDFE2C@git1-us-west.apache.org> Date: Fri, 17 Apr 2015 03:11:33 +0000 (UTC) Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5544#issuecomment-93884241 Looks good to me, except some comments on documentation. Thanks for doing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org