Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: mengxr <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-3098-spark@git.apache.org>
In-Reply-To: <git-pr-3098-spark@git.apache.org>
Subject: [GitHub] spark pull request: [MLLIB] SPARK-4231,
 SPARK-3066: Add RankingMet...
Content-Type: text/plain
Message-Id: <20150402234757.41E89E2F58@git1-us-west.apache.org>
Date: Thu,  2 Apr 2015 23:47:57 +0000 (UTC)

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3098#discussion_r27707370
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala ---
    @@ -138,14 +141,122 @@ class MatrixFactorizationModel(
       }
     
       private def recommend(
    -      recommendToFeatures: Array[Double],
    -      recommendableFeatures: RDD[(Int, Array[Double])],
    -      num: Int): Array[(Int, Double)] = {
    -    val scored = recommendableFeatures.map { case (id,features) =>
    -      (id, blas.ddot(features.length, recommendToFeatures, 1, features, 1))
    +    recommendToFeatures: Array[Double],
    +    recommendableFeatures: RDD[(Int, Array[Double])],
    +    num: Int): Array[(Int, Double)] = {
    +    val recommendToVector = Vectors.dense(recommendToFeatures)
    +    val scored = recommendableFeatures.map {
    +      case (id, features) =>
    +        (id, BLAS.dot(recommendToVector, Vectors.dense(features)))
    --- End diff --
    
    and same here. Let's keep this code untouched, which is irrelevant to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org