Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: jkbradley <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-5330-spark@git.apache.org>
In-Reply-To: <git-pr-5330-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and
 gradi...
Content-Type: text/plain
Message-Id: <20150402214431.830C7E2F3E@git1-us-west.apache.org>
Date: Thu,  2 Apr 2015 21:44:31 +0000 (UTC)

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5330#discussion_r27700319
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/treeEnsembleModels.scala ---
    @@ -166,6 +156,56 @@ class GradientBoostedTreesModel(
     
     object GradientBoostedTreesModel extends Loader[GradientBoostedTreesModel] {
     
    +  /**
    +   * Method to compute initial error and prediction as a RDD for the first
    --- End diff --
    
    Doc: "Compute the initial predictions and errors for a dataset for the first iteration of gradient boosting."  No need to say it's a "method."  This is a leftover problem from before, so don't follow previous examples.  : )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org