Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: chenghao-intel <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-5208-spark@git.apache.org>
In-Reply-To: <git-pr-5208-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for
 spark s...
Content-Type: text/plain
Message-Id: <20150402064158.2A214E0389@git1-us-west.apache.org>
Date: Thu,  2 Apr 2015 06:41:58 +0000 (UTC)

Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/5208#issuecomment-88772266
  
    @adrian-wang I leave some comments, but I need some more time in review the code of `SortMergeJoin`, will keep add more comments later. BTW, can you double check if it's reasonable for the `null` value returned in the `SortMergeJoin.Iterator.next`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org