spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6046] [core] Reorganize deprecated conf...
Date Tue, 14 Apr 2015 22:53:34 GMT
GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/5514

     [SPARK-6046] [core] Reorganize deprecated config support in SparkConf. 

    This change tries to follow the chosen way for handling deprecated
    configs in SparkConf: all values (old and new) are kept in the conf
    object, and newer names take precedence over older ones when
    retrieving the value.
    
    Warnings are logged when config options are set, which generally happens
    on the driver node (where the logs are most visible).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-6046

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5514
    
----
commit 2c93209871ae64d5a081c05ed752e121fbb736bf
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2015-04-14T20:24:51Z

    [SPARK-6046] [core] Reorganize deprecated config support in SparkConf.
    
    This change tries to follow the chosen way for handling deprecated
    configs in SparkConf: all values (old and new) are kept in the conf
    object, and newer names take precedence over older ones when
    retrieving the value.
    
    Warnings are logged when config options are set, which generally happens
    on the driver node (where the logs are most visible).

commit ab203511f2fb5e30dfb1fd07b5b387ad63de186c
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2015-04-14T22:44:48Z

    Update FsHistoryProvider to only retrieve new config key.
    
    In the process, deprecate the name that mentions the units
    now that we can define the unit in the config value itself.
    
    Also tweak a couple of messages.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message