spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilganeli <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6746B] Refactor large functions in DAGS...
Date Tue, 07 Apr 2015 17:20:35 GMT
GitHub user ilganeli opened a pull request:

    https://github.com/apache/spark/pull/5396

    [SPARK-6746B] Refactor large functions in DAGScheduler to improve readibility

    Hi all. The DAG Scheduler had several very large, complex, and unreadable functions. Specifically,

    ```handleTaskCompletion```, ```cleanupStateForJobAndIndependentStages```, and ```submitMissingTasks```.
This patch is almost exclusively code movement, very little code has changed with the exception
of handling return logic when serializing tasks within ```submitMissingTasks```. 
    
    I believe the final product is much more readable and makes it much easier to understand
what's going on within the DAGScheduler.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilganeli/spark SPARK-6746B

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5396
    
----
commit a63eb72b58014cfbc408be053ab5a22f21abae35
Author: Ilya Ganelin <ilya.ganelin@capitalone.com>
Date:   2015-04-07T17:14:22Z

    [SPARK-6746] Refactored submitMissingTasks, cleanupStateForJobAndIndependentStages, and
handleTaskCompletion

commit c9db10da94f066109b915d24c3f0f3ec7ee50eea
Author: Ilya Ganelin <ilya.ganelin@capitalone.com>
Date:   2015-04-07T17:19:55Z

    Updated shuffle map task

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message