spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7120][SPARK-7121] Closure cleaner nesti...
Date Wed, 29 Apr 2015 18:03:50 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5685#discussion_r29362732
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1627,7 +1627,10 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
           partitions: Seq[Int],
           allowLocal: Boolean
           ): Array[U] = {
    -    runJob(rdd, (context: TaskContext, iter: Iterator[T]) => func(iter), partitions,
allowLocal)
    +    // We must clean `func` here before using it in another closure below
    +    // Otherwise, the closure cleaner will only clean the outer closure but not `func`
    +    val cleanedFunc = clean(func)
    --- End diff --
    
    Ok, I have decided to fix this in a separate patch since it's really a separate issue.
I have filed [SPARK-7237](https://issues.apache.org/jira/browse/SPARK-7237) for that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message