spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7056][Streaming] Make the Write Ahead L...
Date Wed, 29 Apr 2015 03:48:51 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5645#discussion_r29308665
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/FileBasedWriteAheadLogSegment.scala
---
    @@ -17,4 +17,5 @@
     package org.apache.spark.streaming.util
     
     /** Class for representing a segment of data in a write ahead log file */
    -private[streaming] case class WriteAheadLogFileSegment (path: String, offset: Long, length:
Int)
    +private[streaming] case class FileBasedWriteAheadLogSegment(path: String, offset: Long,
length: Int)
    --- End diff --
    
    I have been thinking the same. The consistent way would be `FileBasedWriteAheadLogRecordHandle`.
That is super super long. :( So I kept it as segment. I think its better of the two options.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message