spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...
Date Tue, 28 Apr 2015 20:40:25 GMT
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r29286003
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
    @@ -182,6 +195,8 @@ private[spark] object CoarseGrainedExecutorBackend extends Logging
{
           workerUrl.foreach { url =>
             env.rpcEnv.setupEndpoint("WorkerWatcher", new WorkerWatcher(env.rpcEnv, url))
           }
    +      env.actorSystem.awaitTermination()
    --- End diff --
    
    I don't think we need both awaitTerminations here.  The rpcEnv would cover the actor one
so could just do the stop after that.
    
    From SparkEnv:
        val rpcEnv = RpcEnv.create(actorSystemName, hostname, port, conf, securityManager)
        val actorSystem = rpcEnv.asInstanceOf[AkkaRpcEnv].actorSystem


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message