spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-4550. In sort-based shuffle, store map o...
Date Mon, 27 Apr 2015 17:48:00 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4450#discussion_r29171158
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
    @@ -113,11 +114,21 @@ private[spark] class ExternalSorter[K, V, C](
         if (shouldPartition) partitioner.get.getPartition(key) else 0
       }
     
    +  private val metaInitialRecords = conf.getInt("spark.shuffle.sort.metaInitialRecords",
256)
    +  private val kvChunkSize = conf.getInt("spark.shuffle.sort.kvChunkSize", 8192)
    --- End diff --
    
    Yeah, I definitely don't think we should expect to tune this in normal operation.  My
thinking was not to document it and mainly to make it accessible if people want to play around
with it for benchmarking, but I can take it out too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message