spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scwf <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7163] [SQL] minor refactory for HiveQl
Date Mon, 27 Apr 2015 08:03:23 GMT
Github user scwf commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5715#discussion_r29126734
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -81,11 +81,38 @@ class HiveContext(sc: SparkContext) extends SQLContext(sc) {
       protected[sql] def convertCTAS: Boolean =
         getConf("spark.sql.hive.convertCTAS", "false").toBoolean
     
    -  override protected[sql] def executePlan(plan: LogicalPlan): this.QueryExecution =
    -    new this.QueryExecution(plan)
    +  /* A catalyst metadata catalog that points to the Hive Metastore. */
    +  @transient
    +  override protected[sql] lazy val catalog = new HiveMetastoreCatalog(this) with OverrideCatalog
    --- End diff --
    
    reorder to make catalog, functionRegistry, analyzer, sqlParser togethor  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message