spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5253] [ML] LinearRegression with L1/L2 ...
Date Fri, 24 Apr 2015 22:36:19 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4259#discussion_r29091445
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -42,34 +50,122 @@ private[regression] trait LinearRegressionParams extends RegressorParams
     class LinearRegression extends Regressor[Vector, LinearRegression, LinearRegressionModel]
       with LinearRegressionParams {
     
    -  setDefault(regParam -> 0.1, maxIter -> 100)
    -
    -  /** @group setParam */
    +  /**
    +   * Set the regularization parameter.
    +   * Default is 0.0.
    +   * @group setParam
    +   */
       def setRegParam(value: Double): this.type = set(regParam, value)
    +  setDefault(regParam -> 0.0)
    --- End diff --
    
    Could we set something like `0.01` with L2? Having zero regularization is not a good practice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message