spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7051] [SQL] Configuration for parquet d...
Date Thu, 23 Apr 2015 05:41:26 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5630#discussion_r28937606
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
    @@ -36,6 +36,8 @@ private[spark] object SQLConf {
       val PARQUET_INT96_AS_TIMESTAMP = "spark.sql.parquet.int96AsTimestamp"
       val PARQUET_CACHE_METADATA = "spark.sql.parquet.cacheMetadata"
       val PARQUET_COMPRESSION = "spark.sql.parquet.compression.codec"
    +  val PARQUET_BLOCK_SIZE = "spark.sql.parquet.blocksize"
    +  val PARQUET_PAGE_SIZE = "spark.sql.parquet.pagesize"
    --- End diff --
    
    At least we need to add the prefix `spark.sql.`, right? like the what we did for `spark.sql.parquet.compression.codec`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message