spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6356][SQL] Support the ROLLUP/CUBE/GROU...
Date Tue, 21 Apr 2015 23:01:18 GMT
Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/5080#issuecomment-94966989
  
    My biggest comment is that we probably should avoid adding new keywords to the SQLParser.
 While this might be a nice feature to have, you can already do it through HiveQL and you
are going to break existing code that uses column names `SETS`, `WITH`, `GROUPING`, `CUBE`,
etc.  As a result I think we should close this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message