spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6490][Core] Add spark.rpc.* and depreca...
Date Mon, 20 Apr 2015 19:10:35 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5595#discussion_r28719078
  
    --- Diff: core/src/main/scala/org/apache/spark/util/RpcUtils.scala ---
    @@ -32,4 +35,24 @@ object RpcUtils {
         Utils.checkHost(driverHost, "Expected hostname")
         rpcEnv.setupEndpointRef(driverActorSystemName, RpcAddress(driverHost, driverPort),
name)
       }
    +
    +  /** Returns the configured number of times to retry connecting */
    +  def numRetries(conf: SparkConf): Int = {
    +    conf.getInt("spark.rpc.num.retries", 3)
    +  }
    +
    +  /** Returns the configured number of milliseconds to wait on each retry */
    +  def retryWaitMs(conf: SparkConf): Long = {
    +    conf.getLong("spark.rpc.retry.wait", 3000)
    +  }
    +
    +  /** Returns the default Spark timeout to use for Rpc ask operations. */
    +  def askTimeout(conf: SparkConf): FiniteDuration = {
    +    conf.getLong("spark.rpc.askTimeout", 30) seconds
    --- End diff --
    
    should these be set to the default network timeout?
    
    same for lookupTimeout


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message