spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: Minor fix to SPARK-6958: Improve Python docstr...
Date Fri, 17 Apr 2015 19:33:13 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5558#discussion_r28623405
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -519,7 +520,7 @@ def sort(self, *cols, **kwargs):
                 jcols = [jc if asc else jc.desc()
                          for asc, jc in zip(ascending, jcols)]
             else:
    -            raise TypeError("ascending can only be bool or list, but got %s" % type(ascending))
    +            raise TypeError("ascending can only be boolean or list, but got %s" % type(ascending))
    --- End diff --
    
    Alright I removed int, since 1, 0 has the same value as True, False anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message