spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [Project Infra] SPARK-1684: Merge script shoul...
Date Fri, 17 Apr 2015 04:31:41 GMT
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/5149#issuecomment-93891216
  
    Hey @texasmichelle thanks for contributing this. It slipped of my radar but it will be
nice to get something like this in. One thing though, even though I originally intended the
format to be "SPARK XXX", in practice, pretty much every contributor now puts brackets around
that part /cc @srowen. So it has now sort of become the de-facto standard!
    
    We should probably update this page to simply tell people to put brackets:
    https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
    
    So I think what we really want now is to coerce the presence of brackets rather than remove
it! If you look at some recent titles, a few of them have this problem.
    https://git-wip-us.apache.org/repos/asf?p=spark.git;a=shortlog
    
    Sorry for some delay in reviewing this, I can address any updates promptly in the next
week. Maybe we can start with that pretty simple rule, and then we can expand in subsequent
patches to do fancier stuff.
    
    The broad organization here looks good.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message