spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4286] Add an external shuffle service t...
Date Thu, 16 Apr 2015 17:34:10 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4990#discussion_r28531482
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/ExternalShuffleService.scala
---
    @@ -64,3 +67,39 @@ class StandaloneWorkerShuffleService(sparkConf: SparkConf, securityManager:
Secu
         }
       }
     }
    +
    +/**
    + * A main class for running the external shuffle service.
    + */
    +object ExternalShuffleService extends Logging {
    +  @volatile
    +  private var server: ExternalShuffleService = _
    +
    +  private val barrier = new CountDownLatch(1)
    +
    +  def main(args: Array[String]): Unit = {
    +    val sparkConf = new SparkConf
    +    Utils.loadDefaultSparkProperties(sparkConf)
    +    val securityManager = new SecurityManager(sparkConf)
    +
    +    // we override this value since this service is started from the command line
    +    // and we assume the user really wants it to be running
    +    sparkConf.set("spark.shuffle.service.enabled", "true")
    --- End diff --
    
    This is kind of weird. I would just add a `start` method in the shuffle service that ignores
this flag. Really I think the flag should be checked outside of the shuffle service before
instantiating an instance of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message