spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ogrisel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4897] [PySpark] Python 3 support
Date Wed, 15 Apr 2015 20:50:46 GMT
Github user ogrisel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5173#discussion_r28461471
  
    --- Diff: python/pyspark/cloudpickle.py ---
    @@ -40,164 +40,126 @@
     NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
     SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     """
    -
    +from __future__ import print_function
     
     import operator
     import os
    +import io
     import pickle
     import struct
     import sys
     import types
     from functools import partial
     import itertools
    -from copy_reg import _extension_registry, _inverted_registry, _extension_cache
    -import new
     import dis
     import traceback
    -import platform
    -
    -PyImp = platform.python_implementation()
    -
     
    -import logging
    -cloudLog = logging.getLogger("Cloud.Transport")
    --- End diff --
    
    Maybe you can join us on gitter.im:
    
    https://gitter.im/cloudpipe/cloudpickle
    
    @rgbkrk @sdegryze and I can also join the spark-dev mailing list if your really want to.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message