spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6807] [SparkR] Merge recent SparkR-pkg ...
Date Wed, 15 Apr 2015 18:52:52 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5436#discussion_r28450544
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala ---
    @@ -39,8 +39,34 @@ private[r] object SQLUtils {
         arr.toSeq
       }
     
    -  def createDF(rdd: RDD[Array[Byte]], schemaString: String, sqlContext: SQLContext):
DataFrame = {
    -    val schema = DataType.fromJson(schemaString).asInstanceOf[StructType]
    +  def createStructType(fields : Seq[StructField]): StructType = {
    --- End diff --
    
    minor style nit: no space between fields and `:` here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message