spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...
Date Wed, 15 Apr 2015 03:29:21 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5350#discussion_r28391203
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
    @@ -284,9 +321,9 @@ object CatalystTypeConverters {
           row: Row,
           schema: StructType,
           converters: Array[Any => Any]): Row = {
    -    val ar = new Array[Any](row.size)
    +    val ar = new Array[Any](converters.size)
         var idx = 0
    -    while (idx < row.size) {
    +    while (idx < converters.size && idx < row.size) {
    --- End diff --
    
    For HiveQuerySuite "Add JAR command 2", the size of row is 1, but the number of fields
is 0, maybe Hive 1.3 has changed the result?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message