spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5946][Streaming] Add Python API for dir...
Date Tue, 14 Apr 2015 05:27:23 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4723#discussion_r28301414
  
    --- Diff: python/pyspark/streaming/kafka.py ---
    @@ -70,7 +71,103 @@ def createStream(ssc, zkQuorum, groupId, topics, kafkaParams={},
             except Py4JJavaError, e:
                 # TODO: use --jar once it also work on driver
                 if 'ClassNotFoundException' in str(e.java_exception):
    -                print """
    +                KafkaUtils._printErrorMsg(ssc.sparkContext)
    +            raise e
    +        ser = PairDeserializer(NoOpSerializer(), NoOpSerializer())
    +        stream = DStream(jstream, ssc, ser)
    +        return stream.map(lambda (k, v): (keyDecoder(k), valueDecoder(v)))
    +
    +    @staticmethod
    +    def createDirectStream(ssc, brokerList, topics, kafkaParams={},
    --- End diff --
    
    That is quite tricky. And its not even clear to me what the demand will be for this from
the Python API. What I wanted to have in the Python aPI is the ability to specify starting
offsets.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message