spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6703][Core][WIP] Provide a way to disco...
Date Tue, 14 Apr 2015 05:17:58 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5501#discussion_r28301202
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1855,6 +1855,19 @@ object SparkContext extends Logging {
       }
     
       /**
    +   * Because we can only have one active Spark Context per JVM and there are times when
multiple
    +   * applications may wish to share a SparkContext, this function may be used to get
or instantiate
    +   * a SparkContext and register it as a singleton object. 
    +   */
    +  private[spark] def getOrCreate(config: SparkConf = new SparkConf()): SparkContext =
{
    --- End diff --
    
    this should be public, shouldn't it?
    
    also would be better to avoid using default value. just overload the function.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message