spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2669] [yarn] Distribute client configur...
Date Mon, 13 Apr 2015 16:01:33 GMT
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4142#discussion_r28251368
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -303,6 +326,59 @@ private[spark] class Client(
       }
     
       /**
    +   * Create an archive with the Hadoop config files for distribution.
    +   *
    +   * These are only really used by the AM, since executors will use the configuration
object
    +   * broadcast by the driver. But this is the easiest way to make sure the files are
available for
    --- End diff --
    
    So is this comment true, is it only really needed by the AM or do we need it on the executors
for things like hive-site.xml?  If its true then we should change our call to ClientDistributedCacheManager.addResource
to pass in the flag to make it appMasterOnly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message