spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6734] [SQL] Add UDTF.close support in G...
Date Sun, 12 Apr 2015 18:09:57 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5383#discussion_r28205769
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
    @@ -75,9 +78,15 @@ case class Generate(
                 outputRows.map(or => joinProjection(joinedRow(row, or)))
               }
             }
    +      }.mapPartitions { iter =>
    +        val nullOriginalRow = Row(Seq.fill(generator.output.size)(Literal(null)): _*)
    +        val joinedRow = new JoinedRow
    +        iter ++ boundGenerator.terminate().map(joinedRow(nullOriginalRow, _))
           }
         } else {
    -      child.execute().mapPartitions(iter => iter.flatMap(row => boundGenerator.eval(row)))
    -    }
    +      child.execute().mapPartitions(iter =>
    +        iter.flatMap(row => boundGenerator.eval(row))
    +      )
    +    }.mapPartitions(_ ++ boundGenerator.terminate())
    --- End diff --
    
    This should only be added when `join` is false. Move it to the above line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message