spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-6735:[YARN] Adding properties to disable...
Date Fri, 10 Apr 2015 12:05:27 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5449#discussion_r28139245
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -94,6 +98,14 @@ private[yarn] class YarnAllocator(
       // Additional memory overhead.
       protected val memoryOverhead: Int = sparkConf.getInt("spark.yarn.executor.memoryOverhead",
         math.max((MEMORY_OVERHEAD_FACTOR * executorMemory).toInt, MEMORY_OVERHEAD_MIN))
    +
    +  // Make the maximum executor failure check to be relative with respect to duration
    +  private val relativeMaxExecutorFailureCheck = 
    --- End diff --
    
    Isn't this more easily solved by considering max failures to be per batch interval or
something? why define another different window of time in another property?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message