spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2033] Automatically cleanup checkpoint
Date Fri, 10 Apr 2015 01:04:47 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/855#discussion_r28116623
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala ---
    @@ -92,8 +92,13 @@ private[spark] class RDDCheckpointData[T: ClassTag](@transient rdd:
RDD[T])
         // Save to file, and reload it as an RDD
         val broadcastedConf = rdd.context.broadcast(
           new SerializableWritable(rdd.context.hadoopConfiguration))
    -    rdd.context.runJob(rdd, CheckpointRDD.writeToFile[T](path.toString, broadcastedConf)
_)
         val newRDD = new CheckpointRDD[T](rdd.context, path.toString)
    +    if (rdd.conf.getBoolean("spark.cleaner.referenceTracking.cleanCheckpoints", false))
{
    --- End diff --
    
    I don't think we should have this config. If the cleaner is not defined then we probably
won't clean the checkpoints anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message