spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingCat <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1706: Allow multiple executors per worke...
Date Thu, 09 Apr 2015 23:19:12 GMT
Github user CodingCat commented on the pull request:

    https://github.com/apache/spark/pull/731#issuecomment-91379206
  
    BTW, I didn't move 'coresPerExecutor' (https://github.com/apache/spark/commit/bc828200402981cd759dd63e04718fe9ea737e06#diff-d3a68f6983a8c3c441b61fe776d77ffdR29)
to be close to memoryPerExecutorMB, since it has a default value on that, 
    
    a parameter with the default locating in the middle of the parameter list makes the statement
calling that function a bit weird (command does not have a default value)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message