spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: WIP: Testing to see whether this fixes the yar...
Date Thu, 09 Apr 2015 21:51:59 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5441#discussion_r28106502
  
    --- Diff: project/SparkBuild.scala ---
    @@ -426,8 +426,10 @@ object TestSettings {
         fork := true,
         // Setting SPARK_DIST_CLASSPATH is a simple way to make sure any child processes
         // launched by the tests have access to the correct test-time classpath.
    -    envVars in Test += ("SPARK_DIST_CLASSPATH" ->
    -      (fullClasspath in Test).value.files.map(_.getAbsolutePath).mkString(":").stripSuffix(":")),
    +    envVars in Test ++= Map(
    +      "SPARK_DIST_CLASSPATH" -> 
    +        (fullClasspath in Test).value.files.map(_.getAbsolutePath).mkString(":").stripSuffix(":"),
    +      "JAVA_HOME" -> sys.props("java.home")),
    --- End diff --
    
    If `JAVA_HOME` was actually set by the user who invoked SBT (or Maven), then I think this
change (and the Maven change) will cause us to ignore their preferred JRE in favor of the
JRE used to launch the build tool, which might be confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message