spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] spark pull request: [SQL] [SPARK-6794] Use kryo-based SparkSqlSeri...
Date Thu, 09 Apr 2015 20:52:05 GMT
Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5433#discussion_r28101404
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
    @@ -46,8 +71,10 @@ private[joins] final class GeneralHashedRelation(hashTable: JavaHashMap[Row,
Com
      * A specialized [[HashedRelation]] that maps key into a single value. This implementation
      * assumes the key is unique.
      */
    -private[joins] final class UniqueKeyHashedRelation(hashTable: JavaHashMap[Row, Row])
    -  extends HashedRelation with Serializable {
    +private[joins] final class UniqueKeyHashedRelation(var hashTable: JavaHashMap[Row, Row])
    --- End diff --
    
    make this private, don't want to expose a mutable field publicly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message